Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only output facetool parameters if enhancing faces #1119

Merged

Conversation

db3000
Copy link
Contributor

@db3000 db3000 commented Oct 16, 2022

A partial solution to #1101, don't print the default facetool parameters if face enhancement is not even enabled. This doesn't solve the saving or loading issue, but it will make the output less confusing.

For example of the prompt text rendering being confusing see: #1108 (comment)

Example with no facetool, no parameters:

invoke> test -s1
[121] outputs/img-samples/000060.1125788153.png: "test" -s 1 -S 1125788153 -W 512 -H 512 -C 7.5 -A k_lms

Example with gfpgan:

invoke> test -s1 -G1
[122] outputs/img-samples/000061.3072109442.png: "test" -s 1 -S 3072109442 -W 512 -H 512 -C 7.5 -A k_lms -G 1.0 -ft gfpgan

Example with codeformer:

invoke> test -s1 -G2 -ft codeformer -cf 0.75
[123] outputs/img-samples/000062.2347390908.png: "test" -s 1 -S 2347390908 -W 512 -H 512 -C 7.5 -A k_lms -G 2.0 -ft codeformer -cf 0.75

Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants