feat(install): unify setup.py, requirements.in, pip #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tildebyte
force-pushed
the
feat-install-unify-setup-requirements-pip
branch
2 times, most recently
from
a702d0d
to
da69ba7
Compare
|
@reviewers: Interesting, important: pypa/setuptools#1983 (comment) TL;DR - from the setuptools maintainers:
|
tildebyte
force-pushed
the
feat-install-unify-setup-requirements-pip
branch
from
da69ba7
to
d6a0d8e
Compare
This allows populating setup.py's 'install_requires' directly from 'requirements.in' - setup.py: - read 'requirements.in' instead of 'requirements.txt' - add correct upstream pytorch repo to "dependency_links" - requirements.in: - append "name @" to git packages - fix torch repo URL -> 'download.pytorch.org/whl/torch_stable.html' Signed-off-by: Ben Alkov <ben.alkov@gmail.com>
tildebyte
force-pushed
the
feat-install-unify-setup-requirements-pip
branch
from
d6a0d8e
to
5a1a36e
Compare
|
Testing now... |
Merged
lstein
added a commit
that referenced
this pull request
Nov 25, 2022
This is the same as PR #1537 except that it removes a redundant `scripts` argument from `setup.py` that appeared at some point. I also had to unpin the github dependencies in `requirements.in` in order to get conda CI tests to pass. However, dependencies are still pinned in `requirements-base.txt` and the environment files, and install itself is working. So I think we are good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows populating setup.py's 'install_requires' directly from 'requirements.in'
ALso tweaked some logging and formatting here and there
Signed-off-by: Ben Alkov ben.alkov@gmail.com