Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(installer) fix syntax error in invoke.sh.in #1727

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

ebr
Copy link
Member

@ebr ebr commented Dec 2, 2022

@blessedcoolant
Copy link
Collaborator

@lstein

@lstein lstein merged commit 6b5d193 into invoke-ai:main Dec 2, 2022
@lstein
Copy link
Collaborator

lstein commented Dec 2, 2022

Thanks! Interestingly extra whitespace does not interfere with bash on Linux. Maybe a MacOS thing? Because the installer pulls from current repo, I thankfully do not have to issue a new patch release for this one.

@ebr ebr deleted the fix-invoke-sh-in branch December 2, 2022 21:14
@keturn
Copy link
Contributor

keturn commented Dec 3, 2022

Wasn't whitespace:

tail -n21 invoke.sh.in | head -n4 |hexyl
 00000000  ef bf bc 69 66 20 5b 20   22 24 28 75 6e 61 6d 65  ×××if [  "$(uname 
 00000010  20 2d 73 29 22 20 3d 3d   20 22 44 61 72 77 69 6e   -s)" ==  "Darwin 
 00000020  22 20 5d 3b 20 74 68 65   6e 0a ef bf bc 20 20 20  " ]; the n_×××    
 00000030  20 65 78 70 6f 72 74 20   50 59 54 4f 52 43 48 5f   export  PYTORCH_ 
 00000040  45 4e 41 42 4c 45 5f 4d   50 53 5f 46 41 4c 4c 42  ENABLE_M PS_FALLB 
 00000050  41 43 4b 3d 31 0a ef bf   bc 66 69 0a ef bf bc 0a  ACK=1_×× ×fi_×××_ 

idk how \xEF\xBF\xBC managed to get in at the beginning of each of those lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Syntax error in invoke.sh. Failed to run on macOS
4 participants