-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global replace [ \t]+$, add "GB" #1751
Conversation
thinkyhead
commented
Dec 3, 2022
- Strip all trailing whitespace from text files.
- Add missing "GB" designation on download size.
I would be more comfortable with this PR if it weren't also changing a bunch of .py and .js files. We'll have to do some extended testing on this to make sure that there wasn't a whitespace change that inadvertently broke something. |
Trailing whitespace removal is 100% safe and will have zero effect on the code. You'll notice that the regex ends in a |
486ed64
to
1873ba7
Compare
Did a quick rebase from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated some images via web and looked over the docs, seems to be fine.
1873ba7
to
2d51800
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!