Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stability and usage improvements to binary & source installers #1760

Merged
merged 1 commit into from
Dec 4, 2022

Conversation

lstein
Copy link
Collaborator

@lstein lstein commented Dec 3, 2022

  • Pass command-line arguments through to invoke.py via the .bat and .sh scripts.
  • Remove obsolete warning message from binary install.bat
  • Make sure that current working directory matches where .bat file is installed
  • Please TEST this on a windows system

- Pass command-line arguments through to invoke.py via the .bat and .sh scripts.
- Remove obsolete warning message from binary install.bat
- Make sure that current working directory matches where .bat file is installed
Copy link
Contributor

@damian0815 damian0815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but i didn't test on a windows system.

@tildebyte
Copy link
Contributor

tildebyte commented Dec 3, 2022

@lstein; The "%~dp0" fix is needed for install.bat.in as well (apparently users some users right-click on the produced 'install.bat', and "Run as Admin" which, insanely enough, defaults to "C:\Windows\System32"...)

GOMEN GOMEN 🙏

Already present; ignore me

@lstein lstein merged commit 38cd968 into main Dec 4, 2022
@lstein lstein deleted the pass-invoke_sh-args branch December 4, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants