Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker push github action and expand with additional metadata #1837

Merged
merged 4 commits into from
Dec 7, 2022

Conversation

ebr
Copy link
Member

@ebr ebr commented Dec 6, 2022

Modifies the cloud image build workflow; rules are as follows:

  • image will be built on all pushes to main, all tags starting with v, and all pull requests.
  • image will NOT be pushed on any pull requests.
  • do NOT perform docker login on pull requests.
  • PR workflows from new contributors will need approval to run. Workflows from forked repo will run in the context of the fork first, and will not have access to any secrets in this repo. Collaborators can examine them before approving workflow runs on this repo.

Image tags added as follows:

  • :latest for the last commit on the repo (any branch or tag, even though it's just main now)
  • :edge for every last commit on main (like :latest but only for main)
  • :main (or other <branch_name>, (even thouh we only run this on main right now)
  • :v1.2.3
  • 1.2.3
  • 1.2
  • cdf4567 (git short SHA)

(I'm open to disabling workflow execution on PRs if that is deemed uncomfortable)

@mauwii mauwii merged commit 1fc1eee into main Dec 7, 2022
@mauwii mauwii deleted the fix-cloud-docker-push branch December 7, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants