add --version to invoke.py arguments #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows invoke.py to print out its name and version number when given the --version argument. I had to move some status messages around in order to make the output clean. There is still an early message about initializing patchmatch that interferes with a clean print of the version, and in fact the --no-patchmatch argument is not doing anything. This will be the subject of a subsequent PR.
Needed to support the web backend.
|
This is ready for review. |
|
I'll try to test this later tonight, but noticed that an empty create_installer.sh file was added - is this intentional? |
mauwii
approved these changes
Dec 20, 2022
ebr
approved these changes
Dec 20, 2022
This is really strange, since it is only empty when viewed in this PR, but when I check out the PR it is not empty, also not empty when I view the File in the Commit itself. So let's knock on wood that this is only a bug in GitHub's WebUI 🙈 |
|
ok, I see what happened - the permissions were adjusted from 0755 to 0644, i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows invoke.py to print out its name and version number when given the --version argument. I had to move some status messages around in order to make the output clean.
There is still an early message about initializing patchmatch that interferes with a clean print of the version, and in fact the --no-patchmatch argument is not doing anything. This will be the subject of a subsequent PR.