propose more restrictive codeowners #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
keturn,
damian0815,
kasbah,
GreggHelt2,
Kyle0654,
ebr,
psychedelicious,
hipsterusername,
JPPhoto,
mauwii,
blessedcoolant,
netsvetaev and
CapableWeb
mauwii
approved these changes
Feb 23, 2023
JPPhoto
approved these changes
Feb 24, 2023
blessedcoolant
approved these changes
Feb 24, 2023
GreggHelt2
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration, here is a revised set of codeowners for the v2.3 branch. The previous set had the bad property that both @blessedcoolant and @lstein were codeowners of everything, meaning that we had the superpower of being able to put in a PR and get full approval if any other member of the team (not a codeowner) approved.
The proposed file is a bit more sensible but needs many eyes on it. Please take a look and make improvements. I wasn't sure where to put some people, such as @netsvetaev or @GreggHelt2
I don't think it makes sense to tinker with the
mainCODEOWNERS until the "Big Freeze" code reorganization happens.I subscribed everyone to this PR. Apologies