Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed startup issues with the web UI. #2876

Merged
merged 2 commits into from Mar 6, 2023
Merged

Fixed startup issues with the web UI. #2876

merged 2 commits into from Mar 6, 2023

Conversation

JPPhoto
Copy link
Contributor

@JPPhoto JPPhoto commented Mar 6, 2023

Fixed an import statement for the web UI server.
Fixed the new run_patches() function to create destination directories if they don't exist.

@psychedelicious
Copy link
Collaborator

This is a duplicate of #2875

@blessedcoolant
Copy link
Collaborator

I fixed the import issue in #2875 but yours has another fix that needs to be made too. I will close my PR. Wouldn't it be better to import from invokeai.frontend.merge rather than going relative?

Either works but just wondering. Closing my PR.

@blessedcoolant blessedcoolant mentioned this pull request Mar 6, 2023
Closed
keturn
keturn approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

psychedelicious
psychedelicious approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model merging works w/ this change, ty

@JPPhoto JPPhoto enabled auto-merge (squash) March 6, 2023 20:39
@JPPhoto
Copy link
Contributor Author

JPPhoto commented Mar 6, 2023

Wouldn't it be better to import from invokeai.frontend.merge rather than going relative?

@blessedcoolant It seemed that everything else in this file used relative syntax so I copied the pattern.

@blessedcoolant
Copy link
Collaborator

Wouldn't it be better to import from invokeai.frontend.merge rather than going relative?

@blessedcoolant It seemed that everything else in this file used relative syntax so I copied the pattern.

All good. Guess this needs a review from @lstein before it is mergeable.

lstein
lstein approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing these problems.

@JPPhoto JPPhoto merged commit c3ff9e6 into main Mar 6, 2023
@JPPhoto JPPhoto deleted the JPPhoto-fix-startup branch March 6, 2023 23:29
@mickr777 mickr777 mentioned this pull request Mar 7, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keturn keturn keturn approved these changes

@lstein lstein lstein approved these changes

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant blessedcoolant approved these changes

@damian0815 damian0815 Awaiting requested review from damian0815

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JPPhoto @psychedelicious @blessedcoolant @keturn @lstein