Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase sha256 chunksize when calculating model hash #3162

Merged
merged 5 commits into from
Apr 25, 2023

Conversation

lstein
Copy link
Collaborator

@lstein lstein commented Apr 9, 2023

  • Thanks to @AbdBarho, who discovered that increasing the chunksize dramatically decreases the amount of time to calculate the hash.

- Thanks to @AbdBarho, who discovered that increasing the chunksize
  dramatically decreases the amount of time to calculate the hash.
@lstein lstein requested a review from ebr April 11, 2023 22:51
Copy link
Member

@ebr ebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in main - LGTM here

@lstein lstein enabled auto-merge April 25, 2023 02:29
@lstein lstein merged commit c0eb1a9 into v2.3 Apr 25, 2023
@lstein lstein deleted the enhance/increase-sha256-chunksize branch April 25, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants