Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to get deterministic image generation behavior (2.3 branch) #3353

Merged
merged 6 commits into from
May 17, 2023

Conversation

lstein
Copy link
Collaborator

@lstein lstein commented May 7, 2023

Resolve non-deterministic behavior when using xformers

This PR updates torch to 2.0.0 and xformers to 0.19. Together these seem to fix the non-deterministic behavior of image generation and I didn't observe any issues on my Linux system. Please evaluate on Windows 10 and Macintosh.

This PR also fixes the documentation for LoRAS, which is giving a 404 error right now, and bumps the version number up to 2.3.5.post1.

Lincoln Stein added 2 commits May 6, 2023 22:29
- torch 2.0.0
- xformers 0.0.19
- compel 1.1.3

2. Fix LoRA documentation so that it shows up in mkdocs.
2. bump version to 2.3.5.post1
@lstein lstein changed the title Update dependencies Update dependencies to remove non-deterministic image generation behavior May 7, 2023
@lstein lstein requested a review from JPPhoto May 7, 2023 02:37
Copy link
Contributor

@JPPhoto JPPhoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but these changes all look good.

@lstein lstein changed the title Update dependencies to remove non-deterministic image generation behavior Update dependencies to get deterministic image generation behavior (2.3 branch) May 7, 2023
@lstein lstein requested a review from GreggHelt2 as a code owner May 7, 2023 23:23
Copy link
Member

@ebr ebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hipsterusername
Copy link
Member

@GreggHelt2 - When you get a chance! :)

Copy link
Contributor

@GreggHelt2 GreggHelt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested starting from scratch with a manual install.
Tested with invokeai --web and invokeai --no-xformers--web. Comparing multiple runs with xformers, without xformers and all params frozen, they all look identical to me. So deterministic image generation appears to be working!

The only issue I had was that specifying --no-xformers in invokeai.init seems to get ignored, or at least on startup xformers is reported as enabled:

UPDATE: turns out problem with invokeai.init was on my end -- everything is working well now.

@hipsterusername hipsterusername merged commit 53f5dfb into v2.3 May 17, 2023
6 checks passed
@hipsterusername hipsterusername deleted the lstein/enhance/update-dependencies branch May 17, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants