Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch generic model errors #4937

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Catch generic model errors #4937

merged 2 commits into from
Oct 18, 2023

Conversation

d8ahazard
Copy link
Contributor

Prevent the app from dying on invalid models.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • [X ] Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • [ X] No, because: Just discovered it, seemed like a simple fix.

Have you updated all relevant documentation?

  • [X ] Yes
  • No

Description

Fix multiple potential issues when scanning models on first load, specifically with an instructPix2Pix model and some non-safetensor files.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

  • Not Applicable
  • Yes
  • No : please replace this line with details on why tests
    have not been included

[optional] Are there any post deployment tasks we need to perform?

Nope.

Prevent the app from dying on invalid models.
Copy link
Collaborator

@RyanJDick RyanJDick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. We're already tolerating a bunch of model load errors - might as well tolerate them all.

We should tidy our error handling in this block, but that can be left for a future PR.

Thanks for this contribution!

@d8ahazard
Copy link
Contributor Author

Seems reasonable to me. We're already tolerating a bunch of model load errors - might as well tolerate them all.

We should tidy our error handling in this block, but that can be left for a future PR.

Thanks for this contribution!

My pleasure! Love the project, doubly so for the new features you guys have been adding.

FWIW, it may also be useful to filter "non-checkpoint" models when scanning, I'm getting a lot of errors for custom metadata files I have alongside my models:

image

@psychedelicious psychedelicious enabled auto-merge (rebase) October 18, 2023 20:20
@psychedelicious psychedelicious merged commit fdf02c3 into invoke-ai:main Oct 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants