-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat (ui): Add VAE Model to Recall Parameters #5073
Conversation
This PR may not be considered "complete" as it does not recall the "default" VAE model if that is selected. |
Last note for tonight, I also noticed that the naming for VAE is a bit inconsistent around the frontend, it seems it is either VAE or VAE Model, but they both refer to the same thing. |
invokeai/frontend/web/src/features/parameters/hooks/useRecallParameters.ts
Show resolved
Hide resolved
Yep as you noted, lets add some additional logic to check if the vae is nullish when recalling all, and if so, set it to null. Looking good otherwise! Stretch goal: check the RTK Query cache when recalling the VAE to ensure it is actually available on the system. Happy to have this be a future change, and we should do the same for when we recall a main model. |
@psychedelicious added the check for nullish variables. It is a bit verbose imo, but I am not sure if it is worth making it harder to read to reduce the code. Also debating on adding similar logic to |
7e4a73d
to
d4f8e6c
Compare
I guess it lead me to question, if the VAE is undefined, it is okay to assume we oughta force the default VAE model on the parameters? |
This behavior makes sense to me |
Agreed, I added that in the latest commit. |
invokeai/frontend/web/src/features/parameters/hooks/useRecallParameters.ts
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/parameters/hooks/useRecallParameters.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @StefanTobler !
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
#4796
Have you updated all relevant documentation?
I don't believe there is any documentation explicitly referencing the recall parameters.
Description
This code changes allows users to recall the VAE model as a Recall Parameter. The VAE model is now part of the "recall all parameters" setting. There is room to add the VAE Precision to the metadata and also making that a recall parameter..
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
vae_recall.mp4
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?