Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): redesign followups #5368

Merged
merged 30 commits into from
Jan 1, 2024
Merged

feat(ui): redesign followups #5368

merged 30 commits into from
Jan 1, 2024

Commits on Jan 1, 2024

  1. fix(ui): fix field title styling

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    e9e05c3 View commit details
    Browse the repository at this point in the history

  2. feat(ui): use make label widths grow 

    Fixes issue where translations overflowed due to hardcoded widths.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    3dc0320 View commit details
    Browse the repository at this point in the history

  3. fix(ui): remove debug stmts

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    6508373 View commit details
    Browse the repository at this point in the history

  4. lru

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    4baffeb View commit details
    Browse the repository at this point in the history

  5. feat(ui): add createLruSelector 

    This uses the previous implementation of the memoization function in reselect. It's possible for the new weakmap-based memoization to cause memory leaks in certain scenarios, so we will avoid it for now.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    9b9003d View commit details
    Browse the repository at this point in the history

  6. feat(ui): use pubsub to for globalcontextmenuclose 

    Far more efficient than the crude redux incrementor thing.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    e38a241 View commit details
    Browse the repository at this point in the history

  7. feat(ui): misc perf/rerender improvements 

    More efficient selectors, memoized/stable references to objects, lazy popover/menu rendering.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    844276e View commit details
    Browse the repository at this point in the history

  8. feat(ui): disable onlyRenderVisibleElements on Flow 

    This can cause stuttering when nodes are being moved in and out of the viewport. I think it's better to improve rendering/perf in other ways.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    b9d431b View commit details
    Browse the repository at this point in the history

  9. feat(ui): misc canvas perf improvements 

    - disable listening when not needed
- use useMemo for gridlines
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    278c67a View commit details
    Browse the repository at this point in the history

  10. feat(ui): bump react-resizable-panels, improve panel resize logic

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    eabb436 View commit details
    Browse the repository at this point in the history

  11. fix(ui): fix uninteractable canvas bbox

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    e19f1ee View commit details
    Browse the repository at this point in the history

  12. feat(ui): canvas perf improvements

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    24cfc5b View commit details
    Browse the repository at this point in the history

  13. chore(ui): bump deps 

    Includes vite v5 - only change needed is to set .mts for vite config files.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    9f30098 View commit details
    Browse the repository at this point in the history

  14. feat(ui): use nanostores for useMouseOverNode 

    This greatly reduces the weight of the event handlers.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    3c3d933 View commit details
    Browse the repository at this point in the history

  15. fix(ui): focus add node popover on open 

    Need an extra ref to pass to the InvSelect component.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    f32ea52 View commit details
    Browse the repository at this point in the history

  16. feat(ui): optimized useMouseOverNode 

    Manually hook into pubsub to eliminate extraneous rerenders on hook change
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    d4151f5 View commit details
    Browse the repository at this point in the history

  17. fix(ui): fix workflow library new workflow/settings closing 

    Need to make the menu not lazy. A better solution is to refactor how the settings works, rendering it in a different part of the component tree
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    0acc758 View commit details
    Browse the repository at this point in the history

  18. feat(ui): bump react-resizable-panels & improve usePanel hook

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    66caf25 View commit details
    Browse the repository at this point in the history

  19. fix(ui): show denoising strength on canvas

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    19fff8d View commit details
    Browse the repository at this point in the history

  20. feat(ui): move canvas interaction state to nanostores 

    This drastically reduces the computation needed when moving the cursor. It also correctly separates ephemeral interaction state from redux, where it is not needed.

Also removed some unused canvas state.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    fd42d1b View commit details
    Browse the repository at this point in the history

  21. feat(ui): store node templates in separate slice 

    Flattens the `nodes` slice. May offer minor perf improvements in addition to just being cleaner.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    95e9b07 View commit details
    Browse the repository at this point in the history

  22. feat(ui): split dnd overlay to separate component 

    This reduces top-level rerenders when zooming in and out on workflow editor
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    3e8df08 View commit details
    Browse the repository at this point in the history

  23. feat(ui): optimized workflow building 

    - Store workflow in nanostore as singleton instead of building for each consumer
- Debounce the build (already was indirectly debounced)
- When the workflow is needed, imperatively grab it from the nanostores, instead of letting react handle it via reactivity
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    375ca9d View commit details
    Browse the repository at this point in the history

  24. feat(ui): update useGlobalModifiers to store each key independently 

    This reduces rerenders when the user presses a modifier key.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    4e13a9f View commit details
    Browse the repository at this point in the history

  25. chore(ui): lint

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    8241043 View commit details
    Browse the repository at this point in the history

  26. feat(ui): use lruMemoize for argsMemoize on selectors 

    This provides a small performance improvement, on the order of a few ms per interaction.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    fa5e81c View commit details
    Browse the repository at this point in the history

  27. fix(ui): InvContextMenu.placement = 'auto-end' 

    This ensures the context menus don't get cut off when the window size is very small.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    04df52b View commit details
    Browse the repository at this point in the history

  28. feat(ui): use zod-less workflow builder when appropriate

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    dfd9c44 View commit details
    Browse the repository at this point in the history

  29. fix(ui): fix dynamic prompts with single prompt 

    Closes #5292

The special handling for single prompt is totally extraneous and caused a bug.
    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    4045103 View commit details
    Browse the repository at this point in the history

  30. chore(ui): lint

    @psychedelicious
    psychedelicious committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    e81476e View commit details
    Browse the repository at this point in the history