Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Header & Other Minor UI Updates #5392

Merged
merged 27 commits into from
Jan 4, 2024

Conversation

blessedcoolant
Copy link
Collaborator

@blessedcoolant blessedcoolant commented Jan 3, 2024

Remove header and incorporate everything else into the side bar and other areas

What type of PR is this? (check all applicable)

  • Refactor

Have you discussed this change with the InvokeAI team?

  • Yes

Description

  • Removes the header entirely from the application and integrates all the elements of the header into other parts -> Logo component in the side panel, settings menu at the bottom and status indicator next to the progress bar which I feel is a very ideal place for this to sit. Because earlier the progress bar was looking like some sort of a divider. I did not know what it was until I started generating. Now it is clear without a doubt that it is an app status feedback item.

opera_AEGzTa2Fkf

  • Updated status and progress bar colors. Live status is now the same color as Invoke Yellow rather than green. They were too close and made no sense to keep both. Replaced the orange of the progress with Invoke Blue. I think this adds much needed contrast to that area and more importantly reduces the usage of yellow-ish tones in the same zone.
opera_0m8JhpriV2.mp4
  • Created a more distinct background for the advanced settings on each accordion.
  • Highlighted the active badges.
  • Tweaked the visuals of the InvExpander - text is bolder (felt it was too thin and easily missable before) and now has an active state color for easy spot.

opera_9Lb8ZAnPEa

  • NOTE: I accidentally merged a local change -- where I increase the saturation of the base color by 4. Personally I prefer this a lot rather than the pure grays. But if you rather stick to the pure grays then I can just undo that one change.

Remove header and incorporate everything else into the side bar and other areas
@blessedcoolant blessedcoolant changed the title feat: Remove Header feat: Remove Header & Other Minor Updates Jan 3, 2024
@blessedcoolant blessedcoolant changed the title feat: Remove Header & Other Minor Updates feat: Remove Header & Other Minor UI Updates Jan 3, 2024
blessedcoolant and others added 21 commits January 4, 2024 04:14
There was an extra div, needed for the fullscreen file upload dropzone, that made styling the main app containers a bit awkward.

Refactor the uploader a bit to simplify this - no longer need so many app-level wrappers. Much cleaner.
too stabby in the eye region
On one hand I like the color but on the other it makes this divider a focus point, which doesn't really makes sense to me. I tried several shades but think it adds a bit too much distraction for your eyes.
just make it like a normal button - normal and hover state, no difference when its expanded. the icon clearly indicates this, and you see the extra components
We are now using the lefthand vertical strip for the settings menu button. This is a good place for the status indicator.

Really, we only need to display something *if there is a problem*. If the app is processing, the progress bar indicates that.

For the case where the panels are collapsed, I'll add the floating buttons back in some form, and we'll indicate via those if the app is processing something.
We can pass a popperjs modifier to the tooltip to give it this padding.
@psychedelicious
Copy link
Collaborator

I've made a number of changes

Settings modal restyled:

settings.modal.mov

Status disconnected indicator:

disconnected.indicator.mov
  • The default state of the app is connected and working - not need to indicate this anywhere
  • The disconnected state is represented by icon in the bottom left corner (and in tooltip on invoke button)
  • The processing status is indicated by the progress bar - no need to indicate this anywhere else

Restored floating buttons:

floating.buttons.mov
  • Same functionality as before. Implementation a bit cleaner.
  • Invoke button shows spinner when processing. I'm not 100% sold on that but there isn't much room otherwise...

Muted colors for badges, bold but not colored expander button:

expander.and.badges.mov

@hipsterusername hipsterusername merged commit d6362ce into invoke-ai:main Jan 4, 2024
7 checks passed
@blessedcoolant blessedcoolant deleted the header-side-new branch January 5, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants