-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove Header & Other Minor UI Updates #5392
Merged
hipsterusername
merged 27 commits into
invoke-ai:main
from
blessedcoolant:header-side-new
Jan 4, 2024
Merged
feat: Remove Header & Other Minor UI Updates #5392
hipsterusername
merged 27 commits into
invoke-ai:main
from
blessedcoolant:header-side-new
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove header and incorporate everything else into the side bar and other areas
2 tasks
There was an extra div, needed for the fullscreen file upload dropzone, that made styling the main app containers a bit awkward. Refactor the uploader a bit to simplify this - no longer need so many app-level wrappers. Much cleaner.
too stabby in the eye region
On one hand I like the color but on the other it makes this divider a focus point, which doesn't really makes sense to me. I tried several shades but think it adds a bit too much distraction for your eyes.
just make it like a normal button - normal and hover state, no difference when its expanded. the icon clearly indicates this, and you see the extra components
We are now using the lefthand vertical strip for the settings menu button. This is a good place for the status indicator. Really, we only need to display something *if there is a problem*. If the app is processing, the progress bar indicates that. For the case where the panels are collapsed, I'll add the floating buttons back in some form, and we'll indicate via those if the app is processing something.
We can pass a popperjs modifier to the tooltip to give it this padding.
I've made a number of changes Settings modal restyled: settings.modal.movStatus disconnected indicator: disconnected.indicator.mov
Restored floating buttons: floating.buttons.mov
Muted colors for badges, bold but not colored expander button: expander.and.badges.mov |
psychedelicious
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove header and incorporate everything else into the side bar and other areas
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Description
opera_0m8JhpriV2.mp4