Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report ci disk space + minor docker fixes #5461

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Conversation

ebr
Copy link
Member

@ebr ebr commented Jan 9, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Description

This PR

  • adds logging of free disk space on the CI runner before and after the disk space cleanup step, to understand how much space we're actually saving and whether the cleanup is sufficient to support the container build. This doesn't fix anything but rather informs our next steps on it.
  • adds a 40-minute timeout to the container build job so that the job isn't clogging up CI for 6 hours if it's unable to proceed
  • updates the UI builder image to nodejs 20.x
  • removes linting step from the UI build in container and runs the build job directly. Linting currently fails for seemingly legitimate reasons, but this should be fixed separately and should not block the build.
  • adds .pnpm-store directories to .gitignore
  • proposes adding @ebr to CODEOWNERS for docker and workflows

QA Instructions, Screenshots, Recordings

  • test this by building and running the container locally: cd docker; docker compose build; docker compose up. The container should build without errors and the application should function as normal
  • with repo admin access, test this in CI by kicking off a container build from this branch

Merge Plan

This PR can be merged when approved

@Millu Millu enabled auto-merge (squash) January 10, 2024 05:19
@Millu Millu merged commit 968fb65 into main Jan 10, 2024
7 checks passed
@Millu Millu deleted the ebr/docker-build-ci-disk-space branch January 10, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants