Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hotkey ux on unified canvas #5592

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

codedealer
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

This PR fixes problems with hotkey interaction on Unified Canvas tab, mostly in regards to staging area toolbar.

  • Gallery items no longer switch when navigating through staging images
  • Quick move tool (when holding space) is properly interactive without having to manually focus on canvas stage
  • The current staging image can be reliably accepted by pressing enter
  • Additionally, pressing ESC while staging discards all images and shift+s saves the current one into gallery

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

  1. Go to Unified Canvas
  2. Select brush tool
  3. Generate images
  4. While in staging mode: navigating with [left] and [right] keys should circle through staging images while the gallery's cursor position should stay the same.
  5. Pressing [shift+s] should save the current staged image to the gallery given it's not hidden ("show results" is "on")
  6. Pressing [enter] should accept the current staged image
  7. Alternatively, Pressing [esc] should discard all images
  8. Right after accepting/discarding staging images (when focus is on window) holding [space] should correctly switch to move tool

Merge Plan

This PR can be merged when approved

Added/updated tests?

No frontend tests

@github-actions github-actions bot added the frontend PRs that change frontend files label Jan 29, 2024
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One issue with the change to the space hotkey.

Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of these issues and improving the UX!

@psychedelicious psychedelicious enabled auto-merge (rebase) January 29, 2024 22:55
@psychedelicious psychedelicious merged commit 4477e04 into invoke-ai:main Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Left/Right arrow losing context
2 participants