workflow tab #5680
Merged
workflow tab #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
requested review from
psychedelicious,
blessedcoolant and
hipsterusername
as code owners
maryhipp
force-pushed
the
maryhipp/workflow-tab
branch
from
5cbec3e
to
19db629
Compare
invokeai/frontend/web/src/features/nodes/components/sidePanel/viewMode/WorkflowWarning.tsx
Outdated
Show resolved
Hide resolved
…t working to switch between within editor tab
…changed and give user choice to reset
- When adding an exposed field, we need to add it to originalExposedFieldValues - When removing an exposed field, we need to remove it from originalExposedFieldValues - add `useFieldValue` and `useOriginalFieldValue` hooks to encapsulate related logic
It was the same as the workflow tab icon, confusing bc you think it's going to somehow take you to the tab.
There was a lot of potentially sensitive logic shared between the new workflow button and menu items. Also, two instances of ConfirmationAlertDialog. Using a render prop deduplicates the logic & components
This was occurring because the `nodesChanged` action is called by reactflow when loading a workflow. Specifically, it calculates and sets the node dimensions as it loads. The existing logic set `isTouched` whenever this action was called. The changes reactflow emits have types, and we can use the change types and data to determine if a change should result in the workflow being marked as touched.
psychedelicious
force-pushed
the
maryhipp/workflow-tab
branch
from
e53b5fe
to
d5ee313
Compare
psychedelicious
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Tidied/fixed a few things:
-
Fixed a longstanding bug where workflows were marked as touched when loading for the first time, or after clicking a node.
-
There are now 3 buttons to save a workflow in edit mode:
- In the side panel
- On the react flow canvas
- In the
...menu at top-right
I don't think we need so many of them - maybe skip the side panel save button?
-
I changed the mode toggle to be an
IconButtonw/ a tooltip.Screen.Recording.2024-02-14.at.7.41.07.pm.mov
-
Also as you can see in the video, I changed the New Workflow icon to be different than the workflow tab icon. I also changed it in the
...menu.
Will defer to you to actually merge @maryhipp
maryhipp
commented
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Edit Mode(what it is today) andView Mode(a view that only exposes the linear fields, if any, for the loaded workflow)Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Merge Plan
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?