Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Seamless Fixes #5685

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Quick Seamless Fixes #5685

merged 3 commits into from
Feb 13, 2024

Conversation

hipsterusername
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • [ X ] Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • [ X ] No, because: It's small

Have you updated all relevant documentation?

  • Yes
  • [ X ] No

Description

This pulls out some of the updates from the WIP Seamless branch that has yet to be completed, and hardcodes values that are exposed in that branch. Given that seamless currently does not generate seamless textures, and this fix results in seamless outputs, it's an improvement even if it doesn't resolve this in a "perfect" way that exposes all variables to the end user.

better over perfect.

f07b7e49-80c2-4659-bb36-d50ec80b1f8b

Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it works

@psychedelicious
Copy link
Collaborator

@blessedcoolant what's actually happening here is a bit beyond me but it works, what do u think

invokeai/backend/model_management/seamless.py Outdated Show resolved Hide resolved
invokeai/backend/model_management/seamless.py Outdated Show resolved Hide resolved
@blessedcoolant
Copy link
Collaborator

@blessedcoolant what's actually happening here is a bit beyond me but it works, what do u think

Seems to me like its mostly a refactor. Has some unnecessary vars in it but the rest seems good.

@hipsterusername
Copy link
Member Author

@blessedcoolant - Merge this, or merge the other. This fixes the issue, and it's currently broken.

@blessedcoolant
Copy link
Collaborator

blessedcoolant commented Feb 11, 2024

@hipsterusername clean up the unused vars in this and merge it. Can worry about the other one (dunno which one) when it's ready. I can do it if you want me to.

@hipsterusername
Copy link
Member Author

feel free to update.

@hipsterusername
Copy link
Member Author

although, i'd actually do one thing - test the skipped layers and see which # you prefer. I'm not sure I actually landed on 0 being the best. might have been 1-2

@blessedcoolant
Copy link
Collaborator

although, i'd actually do one thing - test the skipped layers and see which # you prefer. I'm not sure I actually landed on 0 being the best. might have been 1-2

Does this need to be exposed or can we hardcode?

@hipsterusername
Copy link
Member Author

I think we ought to hardcode the best value - unless you test and find that you like the flexibility.

@psychedelicious
Copy link
Collaborator

I cleaned up the unused stuff

@Millu Millu merged commit 8bd65be into main Feb 13, 2024
8 checks passed
@Millu Millu deleted the SeamlessFixes branch February 13, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants