-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick Seamless Fixes #5685
Quick Seamless Fixes #5685
Conversation
b6ee796
to
ea7b71e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed it works
@blessedcoolant what's actually happening here is a bit beyond me but it works, what do u think |
Seems to me like its mostly a refactor. Has some unnecessary vars in it but the rest seems good. |
@blessedcoolant - Merge this, or merge the other. This fixes the issue, and it's currently broken. |
@hipsterusername clean up the unused vars in this and merge it. Can worry about the other one (dunno which one) when it's ready. I can do it if you want me to. |
feel free to update. |
although, i'd actually do one thing - test the skipped layers and see which # you prefer. I'm not sure I actually landed on 0 being the best. might have been 1-2 |
Does this need to be exposed or can we hardcode? |
I think we ought to hardcode the best value - unless you test and find that you like the flexibility. |
I cleaned up the unused stuff |
43f9f08
to
3339ad4
Compare
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
This pulls out some of the updates from the WIP Seamless branch that has yet to be completed, and hardcodes values that are exposed in that branch. Given that seamless currently does not generate seamless textures, and this fix results in seamless outputs, it's an improvement even if it doesn't resolve this in a "perfect" way that exposes all variables to the end user.
better over perfect.