exposed field loading state #5704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2024 14:51
… loading state for exposed fields
maryhipp
requested review from
psychedelicious,
blessedcoolant and
hipsterusername
as code owners
|
@psychedelicious this works well for me locally, but I am seeing an error in the console (screenshot below). Google tells me this is an RTK thing but I wasn't able to successfully debug it - maybe something I did wrong with error handling in the custom
|
- Rely on RTK Query for the `loadSchema` query by providing a custom `jsonReplacer` in our `dynamicBaseQuery`, so we don't need to manage error state. - Detect when the query was canceled and do not log the error message in those situations.
…s.getOpenAPISchema` - Utilities is for server actions, move this to `appInfo` bc it fits better there. - Rename to match convention for HTTP GET queries. - Fix inverted logic in the `matchRejected` listener (typo'd this)
psychedelicious
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Turns out matchRejected is fired for both failed and canceled requests, and you need to check the mysteriously named action.meta.condition to distinguish between those: https://redux-toolkit.js.org/api/createAsyncThunk#checking-if-a-promise-rejection-was-from-an-error-or-cancellation
Also I made a few small changes, see commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Merge Plan
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?