Remove attention map saving #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
RyanJDick
force-pushed
the
ryan/remove-attention-map-saving
branch
from
5b3adf0
to
890d56b
Compare
RyanJDick
requested review from
lstein,
blessedcoolant,
GreggHelt2,
brandonrising,
hipsterusername and
psychedelicious
as code owners
hipsterusername
approved these changes
Mar 2, 2024
hipsterusername
force-pushed
the
ryan/remove-attention-map-saving
branch
from
890d56b
to
cc45007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Description
Attention map saving was a feature that existed a long time ago in Invoke (>1 year ago). This PR strips out a bunch of dead code that still remains from that feature and is polluting our diffusion implementation.
This change should not have any functional effect on the app.
QA Instructions, Screenshots, Recordings
I did a quick smoke test of SD and SDXL image generation. All of the deleted code was unused, so the risk should be relatively low.
Merge Plan
mainbefore merging.Added/updated tests?