Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate tabs for main model and concepts in generation panel #5848

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

maryhipp
Copy link
Collaborator

@maryhipp maryhipp commented Mar 1, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

UI changes to consolidate the tabs in generation table - now main model and "concepts"/LoRAs appear alongside each other.
Screenshot 2024-03-01 at 10 39 12 AM

@github-actions github-actions bot added the frontend PRs that change frontend files label Mar 1, 2024
@maryhipp maryhipp enabled auto-merge (rebase) March 1, 2024 16:02
@maryhipp maryhipp disabled auto-merge March 1, 2024 16:17
@maryhipp maryhipp enabled auto-merge (rebase) March 1, 2024 16:17
Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine and is more convenient than the two tabs in the original.

Minor nit regarding all the model menus - can the models (main, embeddings and Loras) be sorted alphabetically by name? I'd suggest using case-intensitive sorting.

@maryhipp maryhipp force-pushed the maryhipp/model-parameter-UI branch from 40ccb25 to c3dccd1 Compare March 1, 2024 23:37
@maryhipp maryhipp merged commit 94005b5 into main Mar 4, 2024
14 checks passed
@maryhipp maryhipp deleted the maryhipp/model-parameter-UI branch March 4, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants