refactor: model identifiers improvements #5879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername,
lstein,
GreggHelt2,
brandonrising and
RyanJDick
as code owners
github-actions
bot
added
api
python
maryhipp
reviewed
Mar 6, 2024
invokeai/frontend/web/src/features/nodes/util/graph/addT2IAdapterToLinearGraph.ts
Outdated
Show resolved
Hide resolved
maryhipp
approved these changes
Mar 6, 2024
…rvice These were added as a hold-me-over for the nodes API changes, no longer needed. A followup commit will fix the nodes API to not rely on these.
- All models are identified by a key and optionally a submodel type via new model `ModelField`. Previously, a few model types had their own class, but not all of them. This inconsistency just added complexity without any benefit. - Update all invocation to use the new format. - In the node API, models are loaded by key or an instance of `ModelField` as a convenience. - Add an enriched model schema for metadata. It includes key, hash, name, base and type.
psychedelicious
force-pushed
the
psyche/feat/model-identifiers
branch
from
2357957
to
e7998d4
Compare
hipsterusername
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Description
ModelField. Previously, a few model types had their own class, but not all of them. This inconsistency just added complexity without any benefit.ModelFieldas a convenience.Though the hash is recorded in metadata, it is not used to load models. The client will handle determining the model key for a model with fallback lookup via hash or model attributes. This functionality is not included in this PR, will be a followup (maybe v4.1.0).
With the changes to a lot of the node fields, I also fixed some spots where we had inconsistent capitalization.
QA Instructions, Screenshots, Recordings
Everything should still work in the app, including metadata recall.
Merge Plan
This PR can be merged when approved
Added/updated tests?
have not been included