Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nodes): invocation cache clearing #5880

Merged
merged 5 commits into from
Mar 6, 2024
Merged

fix(nodes): invocation cache clearing #5880

merged 5 commits into from
Mar 6, 2024

Conversation

psychedelicious
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Description

  • Fix issue with invocation cache not clearing when images are deleted.
  • Add tests for invocation cache.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

  • Clear your invocation cache
  • Create a workflow w a single resize image node, ensure cache is enabled for the node
  • Invoke once with save to gallery enabled, once with it disabled
  • Check cache stats, should show size 2
  • Clear intermediates
  • Cache size should reduce to 1

Merge Plan

This PR can be merged when approved

Added/updated tests?

  • Yes
  • No : please replace this line with details on why tests
    have not been included

@psychedelicious
fix(nodes): fix invocation cache ABC typing
a3b2493
@psychedelicious
fix(nodes): fix invocation cache clear method args
e25a3d4
@psychedelicious
fix(nodes): correctly serialize outputs
6ec255f 
In order for delete by match to work, we need the whole invocation output to be stringified.

For some reason, the serialization of the output was set to only include the `type` field. It should instead include the whole output.

I don't understand how this ever worked unless pydantic had different serialization behaviour in v1 (though it appears to have been the same).

Closes #5805
@psychedelicious
tests: add invocation cache tests
f6ed969
@psychedelicious
fix(ui): invalidate InvocationCacheStatus query cache after clearing …
b81d786 
…intermediates
@github-actions github-actions bot added python PRs that change python files services PRs that change app services frontend PRs that change frontend files python-tests PRs that change python tests labels Mar 6, 2024
hipsterusername
hipsterusername approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@hipsterusername hipsterusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 tests

@hipsterusername hipsterusername merged commit fe6e879 into main Mar 6, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/fix/5805-cache-clear branch March 6, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files python PRs that change python files python-tests PRs that change python tests services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Clearing intermediates does not clear node cache
2 participants
@psychedelicious @hipsterusername