Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add config_path to model update form for ckpt models #5883

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat(ui): add config_path to model update form for ckpt models #5883

merged 2 commits into from
Mar 6, 2024

Conversation

maryhipp
Copy link
Collaborator

@maryhipp maryhipp commented Mar 6, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

  • clean up model view/edit screens for checkpoint models
  • add config_path as a field that can be changed for checkpoint models

@github-actions github-actions bot added python PRs that change python files services PRs that change app services frontend PRs that change frontend files labels Mar 6, 2024
@psychedelicious
Copy link
Collaborator

Did we get feedback that this should be user-editable? I removed it on purpose thinking it represented major footgun potential.

@psychedelicious psychedelicious enabled auto-merge (rebase) March 6, 2024 23:09
psychedelicious
psychedelicious approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see via discord that I should not have removed this, sorry! Thanks for restoring it.

@psychedelicious psychedelicious force-pushed the maryhipp/add-config-path-for-ckpt-models branch from 1d596e1 to c7d5f24 Compare March 6, 2024 23:10
@psychedelicious psychedelicious force-pushed the maryhipp/add-config-path-for-ckpt-models branch from c7d5f24 to 8a714f4 Compare March 6, 2024 23:21
@psychedelicious psychedelicious merged commit cdc0d0c into main Mar 6, 2024
14 checks passed
@psychedelicious psychedelicious deleted the maryhipp/add-config-path-for-ckpt-models branch March 6, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files python PRs that change python files services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maryhipp @psychedelicious