Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default processors for controlnet & t2i adapter #5896

Merged
merged 16 commits into from Mar 8, 2024

Conversation

psychedelicious
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Description

  • Make default settings in backend narrowed to individual model type. Main models and ControlNet/T2I Adapters have default settings so far, but they are totally different - main get VAE, CFG Scale, etc, while the control adapters only get preprocessor.
  • Add model probe logic to attempt to autoselect a preprocessor for each control adapter type.
  • Add tests for probe logic.
  • Update UI to use control adapter default_settings to autoselect processor.
  • Update MM tab's default settings - main models have a separate UI from the control adapters.

QA Instructions, Screenshots, Recordings

Use a fresh db so the probe can do its thing when it adds models. Suggest use_memory_db and skip_model_hash options in invokeai.yaml for speed.

  • Select a canny model in MM tab. You should see default processor is canny.
  • Add a ControlNet and select a canny model, processor should default to canny.
  • Back to MM tab, change the default to something else.
  • Change the model away from and back to canny - processor should default to the new selection.

Try another control net and/or t2i adapter.

Merge Plan

This PR can be merged when approved

@github-actions github-actions bot added python PRs that change python files backend PRs that change backend files services PRs that change app services frontend PRs that change frontend files python-tests PRs that change python tests labels Mar 8, 2024
@psychedelicious
Copy link
Collaborator Author

Supersedes #5888

Copy link
Collaborator

@brandonrising brandonrising left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@brandonrising brandonrising force-pushed the psyche/feat/controladapter-defaults branch from 2e43b8a to ec9fe97 Compare March 8, 2024 17:20
@brandonrising brandonrising merged commit 6aae88b into main Mar 8, 2024
14 checks passed
@brandonrising brandonrising deleted the psyche/feat/controladapter-defaults branch March 8, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files frontend PRs that change frontend files python PRs that change python files python-tests PRs that change python tests services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants