New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default processors for controlnet & t2i adapter #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername,
lstein,
GreggHelt2,
brandonrising and
RyanJDick
as code owners
March 8, 2024 09:44
github-actions
bot
added
python
PRs that change python files
backend
PRs that change backend files
services
PRs that change app services
frontend
PRs that change frontend files
python-tests
PRs that change python tests
labels
Mar 8, 2024
Supersedes #5888 |
10 tasks
maryhipp
approved these changes
Mar 8, 2024
brandonrising
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me
Only includes `preprocessor` at this time.
Needed some massaging now that only main models get main model default settings.
…chema This is needed to update Control Adapter defaults.
- Split out main model defaults - Add controlnet/t2i defaults (which includes only the preprocessor)
Wasn't checking for matches correctly.
brandonrising
force-pushed
the
psyche/feat/controladapter-defaults
branch
from
March 8, 2024 17:20
2e43b8a
to
ec9fe97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
PRs that change backend files
frontend
PRs that change frontend files
python
PRs that change python files
python-tests
PRs that change python tests
services
PRs that change app services
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Description
default_settings
to autoselect processor.QA Instructions, Screenshots, Recordings
Use a fresh db so the probe can do its thing when it adds models. Suggest
use_memory_db
andskip_model_hash
options ininvokeai.yaml
for speed.Try another control net and/or t2i adapter.
Merge Plan
This PR can be merged when approved