fix: workflows backcompat #5897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently the schema for models was changed to a generic `ModelField`, and the UI was unable to derive the type of those fields. This didn't affect functionality, but it did break the styling of handles. Add `ui_type` to the affected fields and update the UI to use the correct capitalizations.
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername and
brandonrising
as code owners
github-actions
bot
added
python
psychedelicious
requested review from
lstein,
GreggHelt2 and
RyanJDick
as code owners
github-actions
bot
added
backend
psychedelicious
force-pushed
the
psyche/feat/workflow-backcompat
branch
from
027ee84
to
efac142
Compare
brandonrising
approved these changes
Mar 8, 2024
maryhipp
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Old workflows appear to "just work" (with one caveat*). I really did not expect this. To be honest, I don't really understand how it doesn't explode.
Model related fields were the big question mark, but what actually ends up happening is they show up with an error state, and force you to choose a model.
The only change in this PR is to fix the styling for some field types.
*Caveat: If your workflow was already loaded in the editor and you updating the app, it model fields seem to just not render at all. If you load the workflow after updating the app, the thing I don't understand happens and it works. I maybe able to work that mystery mojo into the app startup but maybe this is good enough?
QA Instructions, Screenshots, Recordings
Load up workflows saved on a previous version. The worst that should happen is you have to re-select models.
Merge Plan
This PR can be merged when approved