Work around missing core conversion model issue #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
blessedcoolant,
GreggHelt2,
brandonrising,
RyanJDick and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Mar 13, 2024
|
I'm suspicious about all the reports being about the same |
- This adds additional logic to the safetensors->diffusers conversion script to check for and install missing core conversion models at runtime. - Fixes #5934
psychedelicious
force-pushed
the
bugfix/install-missing-core-models
branch
from
19a06aa
to
ff6eede
Compare
psychedelicious
added a commit
that referenced
this pull request
Mar 15, 2024
…s a helper function `install_dependencies` to check if the core conversion models are present, whenever we need to convert a model. The configure script installs these conversion models: - `openai/clip-vit-large-patch14`: SD1.x CLIPTokenizer & CLIPTextModel - `stabilityai/stable-diffusion-2`: SD2.x CLIPTokenizer & CLIPTextModel - `CLIP-ViT-bigG-14-laion2B-39B-b160k`: SDXL CLIPTokenizer & CLIPTextConfig (tokenizer 2) The helper function checks for those and one additional model `CLIP-ViT-H-14-laion2B-s32B-b79K`: <https://github.com/invoke-ai/InvokeAI/blob/ff6eede710a0684e6c8d987ac57c9e9277862287/invokeai/backend/model_manager/convert_ckpt_to_diffusers.py#L85> `CLIP-ViT-H-14-laion2B-s32B-b79K` appears to be installed only at runtime, but the codepath appears to be unreachable: `download_from_original_stable_diffusion_ckpt` must be called with `stable_unclip == "img2img"`, which never happens. I don't think we actually need this model installed. This means the helper always fails and thinks a conversion model is missing, leading to the message. Even though no models are missing, we hit the HF API to attempt to install the models, which causes a brief pause. This change resolves the issue: - Use the list of models from the configurator (i.e. everything except `CLIP-ViT-H-14-laion2B-s32B-b79K`) - Extract core models check logic from the `check_root` util into a function and use it in `install_dependencies` Note: This makes the `install_dependencies` check redundant. I don't think the fix in <#5947> is addresses the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
This adds additional logic to the safetensors->diffusers conversion script to check for and install missing core conversion models at runtime.
I am not convinced that this fixes the underlying issue. There is already a check for missing core conversion models when the app starts up and unless the user ran with
--ignore_missing_core_modelswe should never reach a state where the conversion script cannot find its models!Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Merge Plan
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?