Stop registering and moving models which have symlinks in the models dir #5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonrising
requested review from
blessedcoolant,
psychedelicious and
hipsterusername
as code owners
github-actions
bot
added
python
psychedelicious
force-pushed
the
stop-moving-symlinks-in-models-dir
branch
from
1b4d4a7
to
96453f6
Compare
psychedelicious
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Currently, if there's a model in your models directory that was added via symlink, the model install service will resolve the symlink and move the model. This will stop that behavior and leave it in place.
If a user symlinks the model to the wrong directory in the models dir, it will still move the model. Not sure how we want to handle that situation.
QA Instructions, Screenshots, Recordings
Add a model to your models dir using a symlink and start the app. On main, it'd resolve the symlink and move the model. Now it should handle it as expected.
Merge Plan
This PR can be merged when approved