feat(mm): use blake3_single as default hashing algo #6020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
lstein,
blessedcoolant,
GreggHelt2,
brandonrising,
RyanJDick,
hipsterusername and
ebr
as code owners
github-actions
bot
added
python
psychedelicious
changed the title
maryhipp
approved these changes
Mar 21, 2024
hipsterusername
approved these changes
Mar 21, 2024
For SSDs, `blake3` is about 10x faster than `blake3_single` - 3 files/second vs 30 files/second. For spinning HDDs, `blake3` is about 100x slower than `blake3_single` - 300 seconds/file vs 3 seconds/file. For external drives, `blake3` is always worse, but the difference is highly variable. For external spinning drives, it's probably way worse than internal. The least offensive algorithm is `blake3_single`, and it's still _much_ faster than any other algorithm.
Just make it clearer which is which.
psychedelicious
force-pushed
the
psyche/feat/mm/hash-default-blake3_single
branch
from
6946abd
to
6a980e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For SSDs,
blake3is about 10x faster thanblake3_single- 3 files/second vs 30 files/second.For spinning HDDs,
blake3is about 100x slower thanblake3_single- 300 seconds/file vs 3 seconds/file.For external drives,
blake3is always worse, but the difference is highly variable. For external spinning drives, it's probably way worse than internal.The least offensive algorithm is
blake3_single, and it's still much faster than any other algorithm.Also rename
blake3toblake3_multifor clarity.Related Issues / Discussions
Numerous discussions on discord from users with spinning disks or external drives.
QA Instructions
Enable memory db and start up. You should still get reasonable hashing speeds as it migrates everything.
Merge Plan
N/A
Checklist