fix(nodes): workaround seamless multi gpu error #6076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
lstein,
blessedcoolant,
GreggHelt2,
brandonrising,
RyanJDick and
hipsterusername
as code owners
github-actions
bot
added
python
1 task
hipsterusername
approved these changes
Mar 28, 2024
psychedelicious
force-pushed
the
psyche/fix/nodes/seamless-multi-gpu-6010
branch
from
0d37fb3
to
606790c
Compare
The seamless logic errors when a second GPU is selected. I don't understand why, but a workaround is to skip the model patching when there there are no seamless axes specified. This is also just a good practice regardless - don't patch the model unless we need to. Probably a negligible perf impact. Closes #6010
psychedelicious
force-pushed
the
psyche/fix/nodes/seamless-multi-gpu-6010
branch
from
606790c
to
b35ca37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: This is a partial fix. It doesn't fix seamless in a multi-GPU setup, but it will fix non-seamless generation on a multi-GPU setup.
The seamless logic errors when a second GPU is selected. I don't understand why, but a workaround is to skip the model patching when there there are no seamless axes specified.
This is also just a good practice regardless - don't patch the model unless we need to. Probably a negligible perf impact.
Related Issues / Discussions
Partial fix for #6010
QA Instructions
Needs a machine w/ 2 GPUs to test. Normal generation should work on the second GPU (though we expect the same error if you enable seamless).
Merge Plan
n/a
Checklist