fix(mm): vae conversion #6097
Merged
fix(mm): vae conversion #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in #6072.
Add `dump_path` arg to the converter function & save the model to disk inside the conversion function. This is the same pattern as in the other conversion functions.
psychedelicious
requested review from
lstein,
blessedcoolant,
GreggHelt2,
brandonrising,
RyanJDick and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix VAE conversion. See commits for details.
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1149506274971631688/1224117693532213369
QA Instructions
Empty your disk conversion cache and use a non-diffusers VAE. On
main, we expect an assertion error when loading the VAE. On this branch, no error.Here's a safetensors VAE you can test with: https://huggingface.co/stabilityai/sd-vae-ft-mse-original/resolve/main/vae-ft-mse-840000-ema-pruned.safetensors?download=true
Merge Plan
n/a
Checklist