Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): SDXL clip skip #6378

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

psychedelicious
Copy link
Collaborator

Summary

Uses the same CLIP Skip value for both CLIP1 and CLIP2.

Adjusted SDXL CLIP Skip min/max/markers to be within the valid range (0 to 11).

Related Issues / Discussions

Closes #4583

QA Instructions

  • Try it out, with and without LoRAs (which have a minor graph change to support SDXL CLIP Skip). Shouldn't break anything.
  • This does not change the default CLIP skip value. Don't think we should make a change like that.

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

Uses the same CLIP Skip value for both CLIP1 and CLIP2.

Adjusted SDXL CLIP Skip min/max/markers to be within the valid range (0 to 11).

Closes #4583
@github-actions github-actions bot added the frontend PRs that change frontend files label May 16, 2024
@hipsterusername hipsterusername merged commit 40b4fa7 into main May 16, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/feat/ui/sdxl-clip-skip branch May 16, 2024 11:49
@psychedelicious psychedelicious mentioned this pull request May 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDXL CLIP Skip
2 participants