feat(ui): prevent connections to direct-only inputs #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
force-pushed
the
psyche/fix/ui/prevent-direct-connections
branch
from
4d33181
to
2466c23
Compare
hipsterusername
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor fix. The auto-connect logic would let you connect to direct-only inputs (i.e. inputs without handles). Now it doesn't.
Related Issues / Discussions
n/a
QA Instructions
You shouldn't be able to connect to a direct-only input. Not sure if there's a way for this to happen with core nodes only, but it can happen with some community nodes.
Merge Plan
n/a
Checklist