fix(ui): field ordering & display #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As of the workflow internal state rework, fields were re-ordered when connecting/disconnecting them. With feedback that this was jarring, I've changed the behaviour:
Screen.Recording.2024-05-18.at.8.36.11.am.mov
Also sneaking in a fix for issue with field titles not updating correctly.
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1130288930319761428/1241022691834859621
QA Instructions
Try it out I suppose. There's some minor jank with the positioning of handles during a connection. This is an upstream issue.
Merge Plan
n/a
Checklist