feat: write-only canvas metadata #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canvas images are saved by uploading a blob generated from the HTML canvas element. This means the existing metadata handling, inside the graph execution engine, is not available. To save metadata to canvas images, we need to provide it when uploading that blob. The upload route now has a `metadata` body param. If this is provided, we use it over any metadata embedded in the image.
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername and
brandonrising
as code owners
github-actions
bot
added
api
python
psychedelicious
changed the title
hipsterusername
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Store canvas objects in the metadata for both images generated by canvas graphs and images created when clicking the
Save to Gallerybutton.Canvas objects (images, brush strokes, shapes, masks, etc) are stored as is. There is no recall capability - this is planned only for a future canvas v2, based on the control layers renderer and state management.
Related Issues / Discussions
I don't think we've had any requests for canvas metadata without the ability to recall, so this doesn't resolve any open issues.
QA Instructions
_canvas_objectsproperty in the metadata.Save to Galleryon canvas after generating. Should have_canvas_objectsproperty in the metadata.Merge Plan
n/a
Checklist