-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect http[s] protocol when making socket.io middleware #976
Respect http[s] protocol when making socket.io middleware #976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The splitting of hostname and port is a remnant of old code. Let's just do this:
const { origin } = new URL(window.location.href);
const socketio = io(origin, {
timeout: 60000,
});
Can you please update the PR accordingly? I cannot make code suggestions.
try that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested the revision, all good. Thanks!
This change also worked for me getting it to run in docker behind traefik. |
Would it be appropriate to go ahead and regenerate the frontend and commit it, since that's a thing that's going on in this repo? Very surprised this isn't merged or affecting more folks. |
Ran into this and resolved it a bit differently, replacing 👍 |
@damian0815 - Can you rebase and also do a yarn build? I'll merge once everything is ready |
on it |
@damian0815 - It's possible that @psychedelicious already took care of it. Mentioned that his bundle includes these changes. Given that, if you rebase, I'll go ahead and merge |
2db6733
to
8483da4
Compare
8483da4
to
fd26d79
Compare
@hipsterusername rebased and yarn built |
Closes #973