Fixing missing percent in discount and charge check #patch

invopop · May 13, 2024 · ec2c336 · ec2c336
1 parent f15577d
commit ec2c336
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 11 deletions.
diff --git a/components/bill/invoice/lines.templ b/components/bill/invoice/lines.templ
@@ -219,7 +219,11 @@ templ discountRow(row *bill.Discount, ls *lineSupport) {
 		for _, cat := range ls.categories {
 			<td class="tax">
 				if combo := row.Taxes.Get(cat.Code); combo != nil {
-					@t.L(*combo.Percent)
+					if combo.Percent != nil {
+						@t.L(*combo.Percent)
+					} else {
+						&mdash;
+					}
 				} else {
 					<!-- empty -->
 				}
@@ -286,7 +290,11 @@ templ chargeRow(row *bill.Charge, ls *lineSupport) {
 		for _, cat := range ls.categories {
 			<td class="tax">
 				if combo := row.Taxes.Get(cat.Code); combo != nil {
-					@t.L(*combo.Percent)
+					if combo.Percent == nil {
+						&mdash;
+					} else {
+						@t.L(*combo.Percent)
+					}
 				} else {
 					<!-- empty -->
 				}

diff --git a/components/bill/invoice/lines_templ.go b/components/bill/invoice/lines_templ.go