feat: add missing feedback from bruteforce matcher

Modify `Matcher` base interface so that Error message contains runtime type of overloading class - to ease up debugging.
inway · Sep 1, 2023 · ffdc01e · ffdc01e
1 parent e7eb509
commit ffdc01e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/dart_zxcvbn/lib/src/matcher/bruteforce.dart b/packages/dart_zxcvbn/lib/src/matcher/bruteforce.dart
@@ -40,4 +40,7 @@ class BruteForceMatcher extends Matcher {
 
     return max(guesses, minGuesses);
   }
+
+  @override
+  feedback(EstimatedGuessesMixin match, bool isSoleMatch) => null;
 }
diff --git a/packages/dart_zxcvbn/lib/src/matcher/common.dart b/packages/dart_zxcvbn/lib/src/matcher/common.dart
@@ -26,11 +26,11 @@ abstract interface class Matcher {
 
   /// TODO make this abstract when all matchers are implemented
   dynamic scoring(Match match) {
-    throw UnimplementedError();
+    throw UnimplementedError('scoring() not implemented on $runtimeType');
   }
 
   /// TODO make this abstract when all matchers are implemented
-  Feedback feedback(EstimatedGuessesMixin match, bool isSoleMatch) {
-    throw UnimplementedError();
+  Feedback? feedback(EstimatedGuessesMixin match, bool isSoleMatch) {
+    throw UnimplementedError('feedback() not implemented on $runtimeType');
   }
 }