Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing to use of 'use' to avoid circular includes / redefines #21

Merged
merged 1 commit into from
Jan 20, 2018

Conversation

christopherraa
Copy link
Contributor

Should be able to close #20 after applying this patch.

Same command run as mentioned in the issue:

for file in $( find lib/ -type f ); do perl -Ilib -c $file; done
lib/Mojo/RabbitMQ/Client.pm syntax OK
lib/Mojo/RabbitMQ/Client/Method.pm syntax OK
lib/Mojo/RabbitMQ/Client/Method/Publish.pm syntax OK
lib/Mojo/RabbitMQ/Client/Publisher.pm syntax OK
lib/Mojo/RabbitMQ/Client/Consumer.pm syntax OK
lib/Mojo/RabbitMQ/Client/LocalQueue.pm syntax OK
lib/Mojo/RabbitMQ/Client/Channel.pm syntax OK

Tests have also been run without incident.

@christopherraa christopherraa changed the title Changing to use of 'require' to avoid circular includes / redefines Changing to use of 'use' to avoid circular includes / redefines Jan 20, 2018
@christopherraa
Copy link
Contributor Author

christopherraa commented Jan 20, 2018

I believe the failed build is due to some issue with Travis. I installed 5.22.0 locally and ran tests. Output:

$ perl -v

This is perl 5, version 22, subversion 0 (v5.22.0) built for x86_64-linux
(with 1 registered patch, see perl -V for more detail)

Copyright 1987-2015, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5 source kit.

Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl".  If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.

$ prove 
t/base.t ........ ok   
t/localqueue.t .. ok     
t/publisher.t ... ok   
t/static.t ...... ok   
t/uri.t ......... ok     
t/use.t ......... ok   
All tests successful.
Files=6, Tests=117,  2 wallclock secs ( 0.06 usr  0.02 sys +  1.73 cusr  0.13 csys =  1.94 CPU)
Result: PASS

If possible please re-run tests to see if I in my commit indeed have an error on 5.22.0 or if it is intermittent failure in Travis / the test-suite.

@SPodjasek
Copy link
Member

You're right builds 68 & 69 failed randomly on publisher.t, I'm investigating this issue currently.
Travis runs additional on-line test on RabbitMQ server which is disabled by default (requires TEST_RMQ=1 in %ENV) and it fails...

@SPodjasek SPodjasek merged commit 8490441 into inway:master Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular includes
2 participants