Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent warning about undefined object on closed channels #36

Merged
merged 1 commit into from Aug 20, 2019

Conversation

okurz
Copy link
Contributor

@okurz okurz commented Aug 9, 2019

This prevents warnings like

(in cleanup) Can't call method "_handle" on an undefined value at /usr/lib/perl5/vendor_perl/5.18.2/Mojo/RabbitMQ/Client.pm line 354.

as reported in #30

@okurz
Copy link
Contributor Author

okurz commented Aug 9, 2019

checks fail e.g. in https://travis-ci.org/inway/mojo-rabbitmq-client/jobs/569839402#L384 with "Can't locate Module/Build/Tiny.pm" . Can't help much with that

This prevents warnings like

```
(in cleanup) Can't call method "_handle" on an undefined value at /usr/lib/perl5/vendor_perl/5.18.2/Mojo/RabbitMQ/Client.pm line 354.
```

as reported in inway#30
@kraih
Copy link
Contributor

kraih commented Aug 12, 2019

Looks like the Travis config is not quite right for older Perl versions. Seems safe to ignore those fails.

@SPodjasek SPodjasek closed this Aug 20, 2019
@SPodjasek SPodjasek reopened this Aug 20, 2019
@SPodjasek
Copy link
Member

@okurz @kraih Travis switched it's default distro to xenial recently, and because of that build for older Perl versions fail. I've tweaked some settings to force old Perls to run on trusty, and it seems to help.
Anyway, I'm going to merge and publish this with next patch release.

@SPodjasek SPodjasek merged commit 24ce324 into inway:master Aug 20, 2019
SPodjasek added a commit that referenced this pull request Aug 20, 2019
Changelog diff is:

diff --git a/Changes b/Changes
index eadeda1..85be345 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,7 @@
 {{$NEXT}}

+0.2.4 2019-08-20T00:49:27Z
+  - Prevent warning about undefined object on closed channels #36 (@okurz)
 0.2.3 2019-07-24T21:06:16Z
   - Clarified documentation #33, #34 (@AdamWill)
 0.2.2 2019-05-23T11:20:22Z
@okurz
Copy link
Contributor Author

okurz commented Aug 20, 2019

This is great news. Thank you!

@okurz okurz deleted the feature/cleanup branch August 20, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants