Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocksize fix #22

Merged
merged 3 commits into from
Jul 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/systems/crigges/jmpq3/JMpqEditor.java
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,8 @@ public void close(boolean buildListfile, boolean buildAttributes, boolean recomp
// currentPos += newBlock.getCompressedSize();
// }

newBlockSize = newBlocks.size();

newHashPos = currentPos - (keepHeaderOffset ? headerOffset : 0);
newBlockPos = newHashPos + newHashSize * 16;

Expand Down
45 changes: 41 additions & 4 deletions src/test/java/systems/crigges/jmpq3test/MpqTests.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,16 @@
import systems.crigges.jmpq3.*;
import systems.crigges.jmpq3.security.MPQEncryption;

import java.io.File;
import java.io.FileInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.*;
import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardCopyOption;
import java.util.Arrays;
import java.util.LinkedHashSet;
import java.util.Scanner;
import java.util.Set;

/**
* Created by Frotty on 06.03.2017.
Expand Down Expand Up @@ -330,4 +329,42 @@ public void testRemoveHeaderoffset() throws IOException {
Assert.assertTrue(mpqEditor.isCanWrite());
mpqEditor.close();
}

private Set<File> getFiles(File dir) {
Set<File> ret = new LinkedHashSet<>();

for (File file : dir.listFiles()) {
if (file.isDirectory()) ret.addAll(getFiles(file)); else ret.add(file);
}

return ret;
}

@Test()
public void newBlocksizeBufferOverflow() throws IOException {
File mpq = new File(MpqTests.class.getClassLoader().getResource("newBlocksizeBufferOverflow/mpq/newBlocksizeBufferOverflow.w3x").getFile());

File targetMpq = mpq.toPath().resolveSibling("file1.mpq").toFile();

targetMpq.delete();

Files.copy(mpq.toPath(), targetMpq.toPath(), StandardCopyOption.REPLACE_EXISTING).toFile();

mpq = targetMpq;

String resourceDir = "newBlocksizeBufferOverflow/insertions";

Set<File> files = getFiles(new File(MpqTests.class.getClassLoader().getResource("./" + resourceDir + "/").getFile()));

JMpqEditor mpqEditor = new JMpqEditor(mpq, MPQOpenOption.FORCE_V0);

for (File file : files) {
String inName = file.toString().substring(file.toString().lastIndexOf(resourceDir) + resourceDir.length() + File.separator.length());

mpqEditor.insertFile(inName, file, false);
mpqEditor.insertFile(inName, file, false);
}

mpqEditor.close();
}
}
Binary file not shown.