Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack warning: Critical dependency: the request of a dependency is an expression #30

Closed
nickforddev opened this issue Nov 14, 2018 · 4 comments

Comments

@nickforddev
Copy link

webpack/webpack#196

in ./node_modules/app-root-path/browser-shim.js
Critical dependency: the request of a dependency is an expression

It's not a catastrophic error but it is pretty unfortunate having to filter this error in all of my webpack projects that use it.

@PaulTondeur
Copy link

Would be good if this issue could be resolved.

@inxilpro
Copy link
Owner

Can y'all give me more details or steps to reproduce?

@d-pollard
Copy link

@inxilpro if you use the vue-cli to create a new app: vue create some-app then install this repo, import it in a file and you'll see the error specified

@inxilpro
Copy link
Owner

Version 2.2.0 should address this issue, although this package really doesn't make sense in the context of webpack, so it might be better to remove the browser-shim altogether down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants