Update resolve.js #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method of requiring has changed in electron since version 1.0. This change fixs the "Uncaught Error: Cannot find module 'remote'" error when trying to use "var appRoot = require('app-root-path');" on render side of an Electron app.
|
Nice fix - I'm currently using it and can confirm it solves the issue. Until this is merged if anyone needs the fix you can remove the original and add this to your package.json "app-root-path": "hannes-dahlberg/node-app-root-path#patch-1"Then |
|
Sorry, for some reason didn't notice this before. Taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method of requiring has changed in electron since version 1.0. This change fixs the "Uncaught Error: Cannot find module 'remote'" error when trying to use "var appRoot = require('app-root-path');" on render side of an Electron app.