Skip to content
This repository has been archived by the owner on Apr 29, 2021. It is now read-only.

update state url #1

Closed
wants to merge 4 commits into from

Conversation

alobaidizt
Copy link

@alobaidizt alobaidizt commented Jul 26, 2016

@coveralls
Copy link

coveralls commented Jul 26, 2016

Coverage Status

Coverage remained the same at 60.465% when pulling ab0c4ae on eflexsystems:update-state-url into aa10750 on io-digital:master.

@skibz
Copy link
Member

skibz commented Jul 27, 2016

hey @alobaidizt , thank you for contributing this patch 😄 🙏

does the module work on your webrelay device using stateFull.xml? the documentation states that the difference between state.xml and stateFull.xml is that the latter returns response headers.

if it doesn't work for your device, then perhaps we can work together here to fix this? i'm nervous about immediately merging your changes as we have a production system relying on the stability of this module.

i'm going to set up my webrelay later today and run your code to ensure its integrity.

@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage remained the same at 60.465% when pulling ace53ff on eflexsystems:update-state-url into aa10750 on io-digital:master.

@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage decreased (-4.5%) to 56.0% when pulling 3c11959 on eflexsystems:update-state-url into aa10750 on io-digital:master.

@coveralls
Copy link

coveralls commented Aug 2, 2016

Coverage Status

Coverage decreased (-4.5%) to 56.0% when pulling 1987539 on eflexsystems:update-state-url into aa10750 on io-digital:master.

@skibz skibz closed this Aug 9, 2016
@skibz
Copy link
Member

skibz commented Aug 9, 2016

i have closed this due to inactivity. however, we can explore the possibility of a patch, here, if you can provide sufficient motivation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants