Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licenseInformation field to io-package.json #1092

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

theknut
Copy link
Contributor

@theknut theknut commented Feb 8, 2024

PR Checklist:

  • Provide a meaningful description to this PR or mention which issues this fixes.
  • Ensure the project builds with npm run build
  • Add tests for your change. This includes negative tests (i.e. inputs that need to fail) as well as baseline tests (i.e. how should the directory structure look like?).
  • Run the test suite with npm test
  • If there are baseline changes, review them and make a separate commit for them with the comment "accept baselines" if they are desired changes
  • If you added a required option, also add it to the template creation (.github/create_templates.ts)
  • Add a detailed migration description to docs/updates explaining what the user needs to do when manually updating an existing project
  • Add your changes to CHANGELOG.md (referencing the migration description and this PR or the issue you fixed)

Description:
Since the json schema has been updated to include licenseInformation (ioBroker/ioBroker.js-controller@16ca1dc) all baseline tests are failing. In this PR I added the new property and updated the io-package.json in the baseline templates.
Fixes #1090
fixes: #1087

This PR does not contain

  • Add licenseInformation question to the interview
  • Some more checks may be added

@AlCalzone
Copy link
Collaborator

We've talked about this and do not want to actively advertise the possibility of paid licenses here. Also, we're going to add the license ID to the licenseInformation field to be forwards-compatible.

I'll do the necessary change for that. Thanks for the PR!

@AlCalzone AlCalzone enabled auto-merge (squash) February 12, 2024 12:23
@AlCalzone AlCalzone changed the title feat: add licenseInformation Add licenseInformation field to io-package.json Feb 12, 2024
@AlCalzone AlCalzone enabled auto-merge (squash) February 12, 2024 12:24
@AlCalzone AlCalzone merged commit 4905514 into ioBroker:master Feb 12, 2024
6 checks passed
@theknut theknut deleted the 1090-add-licenseInformation branch February 12, 2024 12:28
AlCalzone added a commit that referenced this pull request Feb 12, 2024
* (theknut) Make ioBroker types available in the test directory (#1091)
* (theknut) Add `licenseInformation` field to `io-package.json` (#1092)
* (AlCalzone) Remove the `subscribe` start mode (#1093)
* (AlCalzone)  Remove the legacy way of creating adapters without classes (#1094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants