Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin ESLint to v8 #1100

Merged
merged 3 commits into from
Apr 8, 2024
Merged

fix: pin ESLint to v8 #1100

merged 3 commits into from
Apr 8, 2024

Conversation

AlCalzone
Copy link
Collaborator

@AlCalzone AlCalzone commented Apr 8, 2024

PR Checklist:

  • Provide a meaningful description to this PR or mention which issues this fixes.
  • Ensure the project builds with npm run build
  • Add tests for your change. This includes negative tests (i.e. inputs that need to fail) as well as baseline tests (i.e. how should the directory structure look like?).
  • Run the test suite with npm test
  • If there are baseline changes, review them and make a separate commit for them with the comment "accept baselines" if they are desired changes
  • If you added a required option, also add it to the template creation (.github/create_templates.ts)
  • Add a detailed migration description to docs/updates explaining what the user needs to do when manually updating an existing project
  • Add your changes to CHANGELOG.md (referencing the migration description and this PR or the issue you fixed)

Description:
This is needed for now until typescript-eslint supports ESLint v9. When that is done, we can migrate to the new config format and update everything ESLint-related.

@AlCalzone AlCalzone enabled auto-merge (squash) April 8, 2024 11:57
@AlCalzone AlCalzone merged commit d91a884 into master Apr 8, 2024
6 checks passed
@AlCalzone AlCalzone deleted the eslint-v8 branch April 8, 2024 12:00
AlCalzone added a commit that referenced this pull request Apr 8, 2024
* (AlCalzone) Pin `eslint` to version 8 (#1100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant