Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Bad wording in setup wizard prevents informed decision making #2484

Open
1 task done
SkyLined opened this issue Jun 1, 2024 · 5 comments
Open
1 task done

Comments

@SkyLined
Copy link
Contributor

SkyLined commented Jun 1, 2024

No existing issues.

  • There is no existing issue for my problem.

Describe the bug

In step 4 of the Initial ioBroker setup, there is a checkbox for "Authentication in Admin" with the text

Activate the check of password in admin if you plan to access your ioBroker is not in "Demilitarized Zone"
This sentence is not welformed English and does not explain what you are being asked to decide. This prevents the user from making a well informed decision.

To Reproduce

  1. Install ioBroker
  2. Goto http://:8081
  3. Go through steps 1-3
  4. At step 4, read the text and try to understand it.

Expected behavior

I expected a clear and concise description of what happens if I check the checkbox vs what happens if I do not check it.

Screenshots & Logfiles

image

Adapter version

N/A

js-controller version

N/A

Node version

N/A

Operating system

N/A

Additional context

No response

@SkyLined SkyLined added the bug label Jun 1, 2024
@SkyLined SkyLined changed the title [bug]: Bad owrding in setup wizard prevents informed decision making [bug]: Bad wording in setup wizard prevents informed decision making Jun 1, 2024
@mcm1957
Copy link
Contributor

mcm1957 commented Jun 1, 2024

@SkyLined
I would suggest to provide a suggestion of the text you would expect.

@SkyLined
Copy link
Contributor Author

SkyLined commented Jun 1, 2024

I would if I had any clue as to what this means. I looked at en, de and nl version and all of them are equally cryptic to me. Since I cannot understand what this does at all, I am unable to submit a patch or offer a suggestion.

@SkyLined
Copy link
Contributor Author

SkyLined commented Jun 1, 2024

I am new to the project, so I do not know what this setting is used for. If somebody can tell me where this setting is used in the code, I might be able to figure it out from that code and offer a better explanation.

@mcm1957
Copy link
Contributor

mcm1957 commented Jun 1, 2024

'authentication in admin' configures wether you must login to use the admin page or (if not checked) no user/password is required. Login is recommended if your installation is reachable from internet - which is generel not recommended (always use ioBroker cloud or an vpn tunnel).

SkyLined added a commit to SkyLined/ioBroker.admin that referenced this issue Jun 1, 2024
The original wording was unclear to me. After it was explained in the comments for [issue 2484](ioBroker#2484), I believe this change best reflects what was originally intended. This should make it easier for users to understand what they are being asked to decide upon.
@SkyLined
Copy link
Contributor Author

SkyLined commented Jun 1, 2024

@mcm1957 Thanks, that makes it much clearer. I've tried to capture what you've said in a patch. Let me know what you think.

GermanBluefox added a commit that referenced this issue Jun 9, 2024
The original wording was unclear to me. After it was explained in the
comments for [issue
2484](#2484), I believe
this change best reflects what was originally intended. This should make
it easier for users to understand what they are being asked to decide
upon.

I only updated the English translation in this edit. In my opinion the
`de` and `nl` versions are similarly confusing and need updates too. I
suspect this also applies to other languages, but I haven't checked.

I can provide these changes for `nl` once this change is accepted.

Co-authored-by: Bluefox <dogafox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants