New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Future] Support coffeescript v2 (requires NodeJS 6+) #70
Comments
No. I don't know if this possibility exists.
2018-02-02 13:03 GMT+01:00 AlCalzone <notifications@github.com>:
… Installing outputs the following warning:
npm WARN deprecated ***@***.***: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
However we cannot just switch the package name because https://github.com/
alexgorbatchev/coffee-compiler also has the old module dependency.
Do you know if there's a possibility to tell NodeJS to actually load
"coffeescript" when requiring "coffee-script"? If so, we could support
CoffeeScript v2.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#70>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AEXqgEDX9QSerE_GJm5jUxfFkZkr5lNgks5tQvmQgaJpZM4R3FlS>
.
|
Yes, you could use https://www.npmjs.com/package/mock-require ... I use this to moch ak´wy serialport with virtual-serialport in some tests for my libraries ... so it is meaned to be used for such, but should work here too.
... could work if you want to "force" it |
Do you asked the owner of coffee-compiler to update the dep or at least prepare an PR :-)) sometimes the easiest way |
That package was last updated 4-5 years ago, I didn't even bother ;) |
Just saw that...I don't really care about coffeescript but: let CoffeeScript = require('coffeescript');
let js = CoffeeScript.compile(obj.common.source, { sourceMap: false, bare: true }); Should be similar to: ioBroker.javascript/javascript.js Lines 435 to 438 in 37e7dc2
Just not in an async way but I doubt that compiling the code can be done async anyway... |
Hmm, that looks very similar indeed. Not sure if the v1 version could not do that or why the additional package was necessary. Maybe I'll give it a 2nd look. |
coffeescript v2 requires at least NodeJS 6, so this is on hold until we drop support for NodeJS 4. |
Now that we have dropped support for NodeJS 4, do you guys think we should pursue this issue further? |
I think that it is OK
сб, 9 июн. 2018 г., 13:48 AlCalzone <notifications@github.com>:
… Now that we have dropped support for NodeJS 4, do you guys think we should
pursue this issue further?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEXqgNG7TORNH-Zk5shEOLFD-Dzbc9e1ks5t67YlgaJpZM4R3FlS>
.
|
Just to say it: did we really dropped Support officially? For latest repo I think yes ;-)) |
We can let the new JavaScript in latest for a while time
вс, 10 июн. 2018 г., 9:07 Ingo Fischer <notifications@github.com>:
… Just to say it: did we really dropped Support officially? For latest repo
I think yes ;-))
Stable we still need to communicate and such
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEXqgG3KzZLBiLH5nGFdR7qot-JMqHYyks5t7MW-gaJpZM4R3FlS>
.
|
I removed coffeescript |
Installing outputs the following warning:
However we cannot just switch the package name because https://github.com/alexgorbatchev/coffee-compiler also has the old module dependency.
Do you know if there's a possibility to tell NodeJS to actually load "coffeescript" when requiring "coffee-script"? If so, we could support CoffeeScript v2.
Of course we could just fork the coffee-compiler, change the dependency and use our fork - but I'm not sure if that's worth the effort.
The text was updated successfully, but these errors were encountered: