diverse mirror fixes #552
Merged
diverse mirror fixes #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bad type in replace logic -> caused some slashes to stay in id, ids of newly created files and files already on disk got different ids. Don't now if that can cause issues, but sure looks better this way.
if you have a tailing slash in diskRoot config variable this will cause a crash on adapter start with the following message "uncaught exception: Cannot read property 'ts' of undefined" This is because an off by one error here: https://github.com/ioBroker/ioBroker.javascript/blob/master/lib/mirror.js#L505 -> i.e. the first letter of the id goes missing there, so this.diskList get's filled with wrong keys and causes this.diskList[id] to be undefined in sync later.
somehow file was used as index in some parts. Probably that got changed was overlooked? -> made those to be in line with rest of the code.
as requested by todo. Also added a try / catch block there.
write is more ciritcal for right issues... we probably don't want a broken sync to crash whole adapter (and create a start-crash-loop). Probably we should wrap all file operations in try / catch blocks.
AlCalzone
reviewed
May 10, 2020
lib/mirror.js
Outdated
| @@ -480,8 +496,8 @@ class Mirror { | |||
| folderDirParts.pop(); | |||
| Mirror.createRecursiveDir(folderDirParts.join('/')); | |||
There was a problem hiding this comment.
If createRecursiveDir fails, should we even continue here?
There was a problem hiding this comment.
We probably should not. Not sure how to best change the situation.
There was a problem hiding this comment.
Ok, had an idea... hope you like it, see e7412ba.
there already was a function to handle the issue... let's just use it. ;-)
it was exlusively used before writeFile, so I added the recursive fs.mkdir there (using path.dirname instead of complicated manual path extraction) and let it throw errors -> if we can not create the dir, we do not try to write the file and print an error instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extended version of #550 - like #550 this should also fix #551
I did some more fixes and cleanup in mirror.js. Those are not as critical and are not really complete, yet, but I lost time to finish them. So maybe it is a good idea to merge them and let me find time to continue improvements later (or somebody else).
Things changed / fixed:
Todo List: